From 66f82f26d51fdfb678033395be3f7d744e75f1ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mike=20Schw=C3=B6rer?= Date: Mon, 12 Nov 2018 18:25:41 +0100 Subject: [PATCH] channel bullshit --- .../simplecloudnotifier/SCNApp.java | 2 + .../model/NotificationSettings.java | 26 ++- .../model/SCNSettings.java | 6 +- .../service/NotificationService.java | 152 +++++++++--------- .../view/SettingsFragment.java | 1 - 5 files changed, 103 insertions(+), 84 deletions(-) diff --git a/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/SCNApp.java b/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/SCNApp.java index a089cd5..1eaf6ef 100644 --- a/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/SCNApp.java +++ b/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/SCNApp.java @@ -118,6 +118,8 @@ public class SCNApp extends Application implements LifecycleObserver [X] - verify recieve +[ ] - Android O repeat sound + [ ] - test notification channels [ ] - publish (+ HN post ?) diff --git a/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/model/NotificationSettings.java b/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/model/NotificationSettings.java index 90d1704..069fb97 100644 --- a/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/model/NotificationSettings.java +++ b/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/model/NotificationSettings.java @@ -1,17 +1,29 @@ package com.blackforestbytes.simplecloudnotifier.model; import android.graphics.Color; +import android.media.RingtoneManager; import android.net.Uri; public class NotificationSettings { - public boolean EnableSound = false; - public String SoundName = ""; - public String SoundSource = Uri.EMPTY.toString(); - public boolean RepeatSound = false; + public boolean EnableSound; + public String SoundName; + public String SoundSource; + public boolean RepeatSound; - public boolean EnableLED = false; - public int LEDColor = Color.BLUE; + public boolean EnableLED; + public int LEDColor; - public boolean EnableVibration = false; + public boolean EnableVibration; + + public NotificationSettings(PriorityEnum p) + { + EnableSound = (p == PriorityEnum.HIGH); + SoundName = (p == PriorityEnum.HIGH) ? "Default" : ""; + SoundSource = (p == PriorityEnum.HIGH) ? RingtoneManager.getDefaultUri(RingtoneManager.TYPE_NOTIFICATION).toString() : Uri.EMPTY.toString(); + RepeatSound = false; + EnableLED = (p == PriorityEnum.HIGH) || (p == PriorityEnum.NORMAL); + LEDColor = Color.BLUE; + EnableVibration = (p == PriorityEnum.HIGH) || (p == PriorityEnum.NORMAL); + } } diff --git a/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/model/SCNSettings.java b/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/model/SCNSettings.java index ff29a44..0500d0a 100644 --- a/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/model/SCNSettings.java +++ b/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/model/SCNSettings.java @@ -48,9 +48,9 @@ public class SCNSettings public boolean Enabled = true; public int LocalCacheSize = 500; - public final NotificationSettings PriorityLow = new NotificationSettings(); - public final NotificationSettings PriorityNorm = new NotificationSettings(); - public final NotificationSettings PriorityHigh = new NotificationSettings(); + public final NotificationSettings PriorityLow = new NotificationSettings(PriorityEnum.LOW); + public final NotificationSettings PriorityNorm = new NotificationSettings(PriorityEnum.NORMAL); + public final NotificationSettings PriorityHigh = new NotificationSettings(PriorityEnum.HIGH); // ------------------------------------------------------------ diff --git a/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/service/NotificationService.java b/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/service/NotificationService.java index 857b28e..48ee393 100644 --- a/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/service/NotificationService.java +++ b/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/service/NotificationService.java @@ -28,9 +28,7 @@ import androidx.core.app.NotificationCompat; public class NotificationService { - private final static String CHANNEL_ID_LOW = "CHAN_BFB_SCN_MESSAGES_LOW"; - private final static String CHANNEL_ID_NORM = "CHAN_BFB_SCN_MESSAGES_NORM"; - private final static String CHANNEL_ID_HIGH = "CHAN_BFB_SCN_MESSAGES_HIGH"; + private final static String CHANNEL_ID = "CHAN_BFB_SCN_MESSAGES"; private final static Object _lock = new Object(); private static NotificationService _inst = null; @@ -56,49 +54,15 @@ public class NotificationService NotificationManager notifman = ctxt.getSystemService(NotificationManager.class); if (notifman == null) return; - NotificationChannel channelLow = notifman.getNotificationChannel(CHANNEL_ID_LOW); - if (channelLow == null) notifman.createNotificationChannel(channelLow = new NotificationChannel(CHANNEL_ID_LOW, "Push notifications (0 - low)", NotificationManager.IMPORTANCE_LOW)); - NotificationChannel channelNorm = notifman.getNotificationChannel(CHANNEL_ID_NORM); - if (channelNorm == null) notifman.createNotificationChannel(channelNorm = new NotificationChannel(CHANNEL_ID_NORM, "Push notifications (1 - normal)", NotificationManager.IMPORTANCE_DEFAULT)); - NotificationChannel channelHigh = notifman.getNotificationChannel(CHANNEL_ID_HIGH); - if (channelHigh == null) notifman.createNotificationChannel(channelHigh = new NotificationChannel(CHANNEL_ID_HIGH, "Push notifications (2 - high)", NotificationManager.IMPORTANCE_HIGH)); - - channelLow.setDescription("Messages from the API with priority set to low"); - updateSingleChannel(channelLow, SCNSettings.inst().PriorityLow, PriorityEnum.LOW); - - channelNorm.setDescription("Messages from the API with priority set to normal"); - updateSingleChannel(channelNorm, SCNSettings.inst().PriorityNorm, PriorityEnum.NORMAL); - - channelHigh.setDescription("Messages from the API with priority set to high"); - updateSingleChannel(channelHigh, SCNSettings.inst().PriorityHigh, PriorityEnum.HIGH); - } - - private void updateSingleChannel(NotificationChannel c, NotificationSettings s, PriorityEnum p) - { - if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) return; - - c.enableLights(s.EnableLED); - c.setLightColor(s.LEDColor); - c.enableVibration(s.EnableVibration); - c.setVibrationPattern(new long[]{500}); - - if (s.EnableSound) + NotificationChannel channel = notifman.getNotificationChannel(CHANNEL_ID); + if (channel == null) { - AudioAttributes attr = new AudioAttributes.Builder() - .setContentType(AudioAttributes.CONTENT_TYPE_SONIFICATION) - .setLegacyStreamType(AudioManager.STREAM_NOTIFICATION) - .setUsage(AudioAttributes.USAGE_NOTIFICATION_EVENT) - .build(); - - c.setSound(Uri.parse(s.SoundSource), attr); + channel = new NotificationChannel(CHANNEL_ID, "Push notifications", NotificationManager.IMPORTANCE_DEFAULT); + channel.setDescription("Push notifications from the server"); + channel.setSound(null, null); + channel.setVibrationPattern(null); + notifman.createNotificationChannel(channel); } - else - { - c.setSound(null, null); - } - - if (p == PriorityEnum.HIGH) c.setBypassDnd(true); - if (p == PriorityEnum.HIGH) c.setLockscreenVisibility(Notification.VISIBILITY_PUBLIC); } public void showForeground(CMessage msg) @@ -120,16 +84,16 @@ public class NotificationService Ringtone rt = RingtoneManager.getRingtone(SCNApp.getContext(), Uri.parse(ns.SoundSource)); if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) rt.setLooping(false); rt.play(); - new Thread(() -> { try { Thread.sleep(2*1000); } catch (InterruptedException e) { /* */ } rt.stop(); }).start(); + new Thread(() -> { try { Thread.sleep(5*1000); } catch (InterruptedException e) { /* */ } rt.stop(); }).start(); } if (ns.EnableVibration) { Vibrator v = (Vibrator) SCNApp.getContext().getSystemService(Context.VIBRATOR_SERVICE); if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { - v.vibrate(VibrationEffect.createOneShot(500, VibrationEffect.DEFAULT_AMPLITUDE)); + v.vibrate(VibrationEffect.createOneShot(1500, VibrationEffect.DEFAULT_AMPLITUDE)); } else { - v.vibrate(500); + v.vibrate(1500); } } } @@ -143,44 +107,86 @@ public class NotificationService { Context ctxt = SCNApp.getContext(); - String channel = CHANNEL_ID_NORM; NotificationSettings ns = SCNSettings.inst().PriorityNorm; switch (msg.Priority) { - case LOW: ns = SCNSettings.inst().PriorityLow; channel = CHANNEL_ID_LOW; break; - case NORMAL: ns = SCNSettings.inst().PriorityNorm; channel = CHANNEL_ID_NORM; break; - case HIGH: ns = SCNSettings.inst().PriorityHigh; channel = CHANNEL_ID_HIGH; break; + case LOW: ns = SCNSettings.inst().PriorityLow; break; + case NORMAL: ns = SCNSettings.inst().PriorityNorm; break; + case HIGH: ns = SCNSettings.inst().PriorityHigh; break; } - NotificationCompat.Builder mBuilder = new NotificationCompat.Builder(ctxt, channel); - mBuilder.setSmallIcon(R.drawable.ic_bfb); - mBuilder.setContentTitle(msg.Title); - mBuilder.setContentText(msg.Content); - mBuilder.setShowWhen(true); - mBuilder.setWhen(msg.Timestamp); - mBuilder.setAutoCancel(true); if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) { - if (msg.Priority == PriorityEnum.LOW) mBuilder.setPriority(NotificationCompat.PRIORITY_LOW); + // old + + NotificationCompat.Builder mBuilder = new NotificationCompat.Builder(ctxt, CHANNEL_ID); + mBuilder.setSmallIcon(R.drawable.ic_bfb); + mBuilder.setContentTitle(msg.Title); + mBuilder.setContentText(msg.Content); + mBuilder.setShowWhen(true); + mBuilder.setWhen(msg.Timestamp * 1000); + mBuilder.setAutoCancel(true); + + if (msg.Priority == PriorityEnum.LOW) mBuilder.setPriority(NotificationCompat.PRIORITY_LOW); if (msg.Priority == PriorityEnum.NORMAL) mBuilder.setPriority(NotificationCompat.PRIORITY_DEFAULT); - if (msg.Priority == PriorityEnum.HIGH) mBuilder.setPriority(NotificationCompat.PRIORITY_HIGH); + if (msg.Priority == PriorityEnum.HIGH) mBuilder.setPriority(NotificationCompat.PRIORITY_HIGH); if (ns.EnableVibration) mBuilder.setVibrate(new long[]{500}); if (ns.EnableLED) mBuilder.setLights(ns.LEDColor, 500, 500); - } - if (ns.EnableSound && !ns.SoundSource.isEmpty()) + if (ns.EnableSound && !ns.SoundSource.isEmpty()) mBuilder.setSound(Uri.parse(ns.SoundSource), AudioManager.STREAM_NOTIFICATION); + + Intent intent = new Intent(ctxt, MainActivity.class); + PendingIntent pi = PendingIntent.getActivity(ctxt, 0, intent, 0); + mBuilder.setContentIntent(pi); + NotificationManager mNotificationManager = (NotificationManager) ctxt.getSystemService(Context.NOTIFICATION_SERVICE); + + Notification n = mBuilder.build(); + if (ns.EnableSound && !ns.SoundSource.isEmpty() && ns.RepeatSound) n.flags |= Notification.FLAG_INSISTENT; + + if (mNotificationManager != null) mNotificationManager.notify(0, n); + } + else { - mBuilder.setSound(Uri.parse(ns.SoundSource), AudioManager.STREAM_NOTIFICATION); + // new + + NotificationCompat.Builder mBuilder = new NotificationCompat.Builder(ctxt, CHANNEL_ID); + mBuilder.setSmallIcon(R.drawable.ic_bfb); + mBuilder.setContentTitle(msg.Title); + mBuilder.setContentText(msg.Content); + mBuilder.setShowWhen(true); + mBuilder.setWhen(msg.Timestamp * 1000); + mBuilder.setAutoCancel(true); + + if (ns.EnableLED) mBuilder.setLights(ns.LEDColor, 500, 500); + + if (msg.Priority == PriorityEnum.LOW) mBuilder.setPriority(NotificationCompat.PRIORITY_LOW); + if (msg.Priority == PriorityEnum.NORMAL) mBuilder.setPriority(NotificationCompat.PRIORITY_DEFAULT); + if (msg.Priority == PriorityEnum.HIGH) mBuilder.setPriority(NotificationCompat.PRIORITY_HIGH); + + Intent intent = new Intent(ctxt, MainActivity.class); + PendingIntent pi = PendingIntent.getActivity(ctxt, 0, intent, 0); + mBuilder.setContentIntent(pi); + NotificationManager mNotificationManager = (NotificationManager) ctxt.getSystemService(Context.NOTIFICATION_SERVICE); + if (mNotificationManager == null) return; + + Notification n = mBuilder.build(); + n.flags |= Notification.FLAG_AUTO_CANCEL; + + mNotificationManager.notify(0, n); + + if (ns.EnableSound && !ns.SoundSource.isEmpty()) + { + Ringtone rt = RingtoneManager.getRingtone(SCNApp.getContext(), Uri.parse(ns.SoundSource)); + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) rt.setLooping(false); + rt.play(); + new Thread(() -> { try { Thread.sleep(5*1000); } catch (InterruptedException e) { /* */ } rt.stop(); }).start(); + } + + if (ns.EnableVibration) + { + Vibrator v = (Vibrator) SCNApp.getContext().getSystemService(Context.VIBRATOR_SERVICE); + v.vibrate(VibrationEffect.createOneShot(1500, VibrationEffect.DEFAULT_AMPLITUDE)); + } } - - Intent intent = new Intent(ctxt, MainActivity.class); - PendingIntent pi = PendingIntent.getActivity(ctxt, 0, intent, 0); - mBuilder.setContentIntent(pi); - NotificationManager mNotificationManager = (NotificationManager) ctxt.getSystemService(Context.NOTIFICATION_SERVICE); - - Notification n = mBuilder.build(); - if (ns.EnableSound && !ns.SoundSource.isEmpty() && ns.RepeatSound) n.flags |= Notification.FLAG_INSISTENT; - - if (mNotificationManager != null) mNotificationManager.notify(0, n); } } diff --git a/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/view/SettingsFragment.java b/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/view/SettingsFragment.java index 647658a..6e3d5eb 100644 --- a/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/view/SettingsFragment.java +++ b/android/app/src/main/java/com/blackforestbytes/simplecloudnotifier/view/SettingsFragment.java @@ -201,7 +201,6 @@ public class SettingsFragment extends Fragment implements MusicPickerListener { SCNSettings.inst().save(); updateUI(); - NotificationService.inst().updateChannels(); } private void onUpgradeAccount()